Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CRater): Responses without ideas are throwing NPE #2079

Merged
merged 1 commit into from
Feb 4, 2025
Merged

fix(CRater): Responses without ideas are throwing NPE #2079

merged 1 commit into from
Feb 4, 2025

Conversation

hirokiterashima
Copy link
Member

Changes

  • When CRater endpoint returned a response without ideas, (in older units like SPOONS-II), the code threw a NPE and the client just hung. I fixed this by adding an optional chaining to exit the loop in such cases.

Test

  • SPOONS-II item works as before.

@hirokiterashima hirokiterashima added the enhancement New feature of any size or improvement (UI, performance, security) label Feb 4, 2025
@hirokiterashima hirokiterashima self-assigned this Feb 4, 2025
@hirokiterashima hirokiterashima marked this pull request as ready for review February 4, 2025 01:05
@hirokiterashima hirokiterashima merged commit d955b2c into develop Feb 4, 2025
5 checks passed
@hirokiterashima hirokiterashima deleted the cRaterService-optional-chaining branch February 4, 2025 01:13
@hirokiterashima
Copy link
Member Author

🎉 This issue has been resolved in version 5.168.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hirokiterashima hirokiterashima

Labels
enhancement New feature of any size or improvement (UI, performance, security) released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hirokiterashima