RAFT v1.3.2 #68
Merged
RAFT v1.3.2 #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to AttributeError: `np.complex_` was removed in the NumPy 2.0 release. Use `np.complex128` instead.
Maybe there's a better option? RegularGridInterpolator is more convoluted than Interp2d
- Reading of cap_d_in from the yaml file was wrong for rectangular elements. Previous code worked for cap_d_in of circular cylinders only. - Fixed interpolation of section properties for rectangular elements - Fixed call to RectangularFrustumMOI() which was with the wrong inputs. - added some checks to avoid division by zero when computing the center of mass of member parts, as some parts can have zero mass depending on modeling choices - Added attributes mshell and mfill to the member class
- 'Q' output from CCBlade was in the 'pitch' spot and 'My' output from CCBlade was in the 'roll' spot - these should be flipped - Also updating the default vapor pressure when calculating cavitation
Updated the true values for test cases that include aerodynamic loads to the bug fix from commit cf839a8 Affected tests: - test_rotor.py: ---- test_calcAero - test_model.py: ---- test_solveStatics_Wind ---- test_solveStatics_Wind_Wave_Current ---- test_solveEigen_loaded ---- test_analyzeCases
Numpy doesn't like `if s_ring:` anymore. Replaced by `if np.any(s_ring)`
The rotor orientation is set internally depending on yaw_mode, but this was done only after computing the inertial properties of the system in solveStatics(). Consequently, the weight of the RNA was acting as if the turbine was at its initial position regardless of yaw_mode. This commit fixes that, and now rotor orientation is updated before computing the inertial properties of the system. I'm still not sure if this fix is 100% correct, so this modification needs to be revised before merging rc1.3.2 into main. The affected tests are the ones with wind in test_model.py. The corresponding true values were updated.
Cannot call fowt.calcTurbineConstants() if not analyzing a `case`, which happens when we call model.analyzeUnloaded()
The total mass and the x coordinate of the center of gravity of the RNA were wrong in `examples/VolturnUS-S_example.yaml`, `tests/test_data/IEA15MW.yaml`, `tests/test_data/VolturnUS-S.yaml` and `tests/test_data/VolturnUS-S_farm.yaml`. Updated the true values of the corresponding tests.
Those tests were in the dev branch (commit 872ab5d) but should be included in release 1.3.2 because concern functionality that is already in the main branch
We were missing the transverse force at the ends of the cylinder from Rainey's formulation
Some input yaml files were using a flag aeroMod instead of aeroServoMod. This does not impact the results because the specified values were the default value (which were used because the correct flag was missing from the yaml files). But hat incorrect flag could mislead users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR includes bug fixes only:
member.getInertia()and cap info for rectangular members (097c264). In particular, fixed a bug when readingcap_d_infrom the yaml file for rectangular elements (previous code to readcap_d_inworked for circular cylinders only).model.solveStatis(). The rotor orientation is set internally depending onyaw_mode, but this was done only after computing the inertial properties of the system insolveStatics(). Consequently, the weight of the RNA was acting as if the turbine was at its initial position regardless ofyaw_mode. Now, rotor orientation is updated before computing the inertial properties of the system. (b5d2591 and 69b8695)examples/VolturnUS-S_example.yaml,tests/test_data/IEA15MW.yaml,tests/test_data/VolturnUS-S.yamlandtests/test_data/VolturnUS-S_farm.yaml(cb14509)aeroServoModwas misspelled in some input files (f69e88b)Changes that do not affect users or previous results:
np.complex_bynp.complex128to comply with NumPy 2.0 (9f1046f)Interp2dhas been removed in SciPy 1.14.0. We are now usingRegularGridInterpolator(331f825)ifstatements inomdao_raft.pyto comply with Numpy 2.0 (c3e9df7)Type of change
What types of change is it?
Testing
All affected tests were updated
Checklist