Permission policy integration. #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backkem
reviewed
Dec 5, 2023
index.bs
Outdated
| Alternatively, the Local Peer-to-Peer API can be disabled completely by specifying the permissions policy in a HTTP response header: | ||
|
|
||
| <pre class="example" title="Permission Policy over HTTP" highlight='js'> | ||
| Permissions-Policy: {"local-peer-to-peer": []} |
There was a problem hiding this comment.
Is there a reason for using a JSON notation here? Maybe we should use the header syntax, e.g.:
Suggested change
| Permissions-Policy: {"local-peer-to-peer": []} | |
| Permissions-Policy: local-peer-to-peer=() |
There was a problem hiding this comment.
Thanks for the suggestion, I will change it.
wangw-1991
commented
Dec 6, 2023
There was a problem hiding this comment.
Thanks @backkem for the great work. Fix some nits, please have a look.
backkem
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add permission policy integration, because this is a powerful API and should be controlled by permission policy.
Preview | Diff