feat: configurable window for profiler peak focus #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgov
requested changes
Dec 25, 2024
| if min_depth is not None and max_depth is not None: | ||
| len_before = data.shape[0] | ||
| data = data[(data[:,0] >= min_depth) & (data[:,0] <= max_depth)] | ||
| rospy.logwarn(f'Profile depths filtered: {min_depth} to {max_depth} m. \ |
There was a problem hiding this comment.
Only concern I have is that this is a warning. I'm guessing because line 130 is a warning, but that was more to do with having erroneous depth readings of DEPTH_PRESSURE_NO_DATA. I think loginfo or just remove the log altogether, since I'm not convinced it's useful?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested and used in the field for constraining where profiler peak may be found