Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Radar driver #138

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Radar driver #138

wants to merge 15 commits into from
+28,721 −37

Conversation

meshvaD
Copy link

@meshvaD meshvaD commented Jul 2, 2024

No description provided.

@meshvaD meshvaD marked this pull request as draft July 2, 2024 12:58
@meshvaD meshvaD force-pushed the md/radar_velocity_det branch from 204db13 to 81041a3 Compare July 2, 2024 13:16
@meshvaD meshvaD force-pushed the md/radar_velocity_det branch from 81041a3 to 736a359 Compare July 11, 2024 04:43
@meshvaD meshvaD force-pushed the md/radar_velocity_det branch from 2396c92 to 18548e9 Compare July 11, 2024 05:19
@rijin113 rijin113 requested review from rijin113 and removed request for rijin113 July 12, 2024 00:27
@meshvaD meshvaD marked this pull request as ready for review July 18, 2024 05:09
@meshvaD meshvaD force-pushed the md/radar_velocity_det branch from 3fa37f0 to 372855b Compare July 18, 2024 05:28
@meshvaD meshvaD force-pushed the md/radar_velocity_det branch from f5c683d to 25971ce Compare July 18, 2024 05:33
@meshvaD meshvaD force-pushed the md/radar_velocity_det branch 2 times, most recently from 5d67525 to 001f042 Compare July 18, 2024 05:53
@meshvaD meshvaD force-pushed the md/radar_velocity_det branch from 001f042 to 9fe4b27 Compare July 18, 2024 06:01
@danielrhuynh danielrhuynh requested a review from Edwardius July 19, 2024 00:20
Edwardius
Edwardius requested changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@Edwardius Edwardius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main changes from infra side:

  • all custom msgs should go into wato_msgs
  • you should place the radar driver into a subdirectory of sensor interfacing (as it s own package, sensor interfracing as a whole should not be it's own package)

src/interfacing/sensor_interfacing/play_can.sh Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this file for?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gonna delete this

src/interfacing/sensor_interfacing/radar_conti_ars408/include/ars_408_can_defines.h
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this file for?

src/interfacing/sensor_interfacing/radar_conti_ars408_msgs/msg/FilterCfg.msg Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these msgs should be in wato_msgs

@Edwardius
Copy link
Collaborator

Sorry, didn't mean to push, this PR might need to be readapted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Edwardius Edwardius Edwardius requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meshvaD @Edwardius