Allow calling colors by name #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to allow calling colors by name, and to allow configuring a color using the traditional 255 based decimal codes. This also allows the "set_**_leds_on" macros to be called from the frontend with a color name.
|
I think the idea is cool, but I really don't think it's necessary to add this to the repo, especailly as an "alt" version to the traditional SB macros. I believe that since this PR was made, both Fluidd and Mainsail give you a color "wheel" that you can use anyway to pick a color for the LEDs. Would hate to possibly confuse users by having 2 separate macro configurations, but that doesn't mean that this isnt desirable! |
|
Is it possible to combine this functionality into the current macros without breaking anything for future users? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to allow calling colors by name, and to allow configuring a color using the traditional 255 based decimal codes.
This also allows the "set_**_leds_on" macros to be called from the frontend with a color name.
I'm not sure if this is the right place to submit this, or if it would even be wanted, but I find it a lot easier to setup the colors and configure the macros this way.