Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Misc tidyup of SMS implementation #513

Merged
merged 2 commits into from
Jan 31, 2024
Merged

refactor: Misc tidyup of SMS implementation #513

merged 2 commits into from
Jan 31, 2024

Conversation

SMadani
Copy link
Contributor

@SMadani SMadani commented Jan 31, 2024

This PR improves test coverage of the SMS API and deprecates classes intended for removal.

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

Merging #513 (bbd3638) into main (730a1a4) will increase coverage by 0.54%.
The diff coverage is 98.07%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #513      +/-   ##
============================================
+ Coverage     95.29%   95.84%   +0.54%     
- Complexity     2933     2974      +41     
============================================
  Files           428      430       +2     
  Lines          6976     6999      +23     
  Branches        403      403              
============================================
+ Hits           6648     6708      +60     
+ Misses          198      165      -33     
+ Partials        130      126       -4     
Files Coverage Δ
...m/vonage/client/auth/hashutils/AbstractHasher.java 83.33% <ø> (ø)
...om/vonage/client/auth/hashutils/HmacMd5Hasher.java 85.71% <ø> (ø)
...m/vonage/client/auth/hashutils/HmacSha1Hasher.java 85.71% <ø> (ø)
...vonage/client/auth/hashutils/HmacSha256Hasher.java 85.71% <ø> (ø)
...vonage/client/auth/hashutils/HmacSha512Hasher.java 85.71% <ø> (ø)
...va/com/vonage/client/auth/hashutils/Md5Hasher.java 100.00% <ø> (ø)
.../java/com/vonage/client/incoming/MessageEvent.java 88.46% <ø> (ø)
...n/java/com/vonage/client/incoming/MessageType.java 100.00% <100.00%> (ø)
...n/java/com/vonage/client/incoming/NotifyEvent.java 100.00% <ø> (ø)
src/main/java/com/vonage/client/sms/HexUtil.java 91.89% <100.00%> (-2.71%) ⬇️
... and 11 more

@SMadani SMadani marked this pull request as ready for review January 31, 2024 17:35
@SMadani SMadani merged commit 3ebff44 into main Jan 31, 2024
15 checks passed
@SMadani SMadani deleted the misc-cleanup branch January 31, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants