Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Type inference hack for fromJson #492

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

SMadani
Copy link
Contributor

@SMadani SMadani commented Nov 1, 2023

This PR adds documentation to the Jsonable class, as well as an overload to infer the type using the varargs trick. It also removes the unused VonageApiResponseException.fromHttpResponse method, and standardises MessageStatus.fromJson.

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2023

Codecov Report

Merging #492 (8718d8a) into main (80a4cdc) will increase coverage by 0.05%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #492      +/-   ##
============================================
+ Coverage     93.90%   93.95%   +0.05%     
+ Complexity     2593     2592       -1     
============================================
  Files           380      380              
  Lines          6532     6521      -11     
  Branches        431      430       -1     
============================================
- Hits           6134     6127       -7     
+ Misses          224      218       -6     
- Partials        174      176       +2     
Files Coverage Δ
src/main/java/com/vonage/client/Jsonable.java 91.30% <100.00%> (+9.48%) ⬆️
.../com/vonage/client/VonageApiResponseException.java 67.39% <100.00%> (+0.72%) ⬆️
...ava/com/vonage/client/account/BalanceResponse.java 100.00% <100.00%> (ø)
...com/vonage/client/account/ListSecretsResponse.java 100.00% <100.00%> (ø)
...m/vonage/client/account/PrefixPricingResponse.java 100.00% <100.00%> (ø)
...ava/com/vonage/client/account/PricingResponse.java 100.00% <100.00%> (ø)
...java/com/vonage/client/account/SecretResponse.java 100.00% <100.00%> (ø)
...va/com/vonage/client/account/SettingsResponse.java 100.00% <100.00%> (ø)
...ava/com/vonage/client/application/Application.java 93.75% <100.00%> (ø)
...com/vonage/client/application/ApplicationList.java 75.00% <100.00%> (ø)
... and 45 more

... and 1 file with indirect coverage changes

@SMadani SMadani merged commit 9b43eea into main Nov 1, 2023
11 checks passed
@SMadani SMadani deleted the fromjson-overload branch November 1, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants