-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: ProactiveConnect to use DynamicEndpoint #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMadani
changed the title
Refactor ProactiveConnect to use DynamicEndpoint
refactor: ProactiveConnect to use DynamicEndpoint
Oct 19, 2023
Codecov Report
@@ Coverage Diff @@
## main #489 +/- ##
============================================
+ Coverage 93.60% 93.62% +0.02%
+ Complexity 2712 2630 -82
============================================
Files 409 393 -16
Lines 6909 6665 -244
Branches 447 429 -18
============================================
- Hits 6467 6240 -227
+ Misses 255 252 -3
+ Partials 187 173 -14
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as previous PRs of this kind. Since the API also includes file uploads and downloads, a new interface has been introduced to facilitate binary request bodies in DynamicEndpoint.
There's some other miscellaneous refactoring here too, such as removing previously deprecated classes & methods from public visibility, and migrating all tests to JUnit 5.