Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ProactiveConnect to use DynamicEndpoint #489

Merged
merged 16 commits into from
Oct 20, 2023
Merged

Conversation

SMadani
Copy link
Contributor

@SMadani SMadani commented Oct 19, 2023

Same as previous PRs of this kind. Since the API also includes file uploads and downloads, a new interface has been introduced to facilitate binary request bodies in DynamicEndpoint.
There's some other miscellaneous refactoring here too, such as removing previously deprecated classes & methods from public visibility, and migrating all tests to JUnit 5.

@SMadani SMadani changed the title Refactor ProactiveConnect to use DynamicEndpoint refactor: ProactiveConnect to use DynamicEndpoint Oct 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2023

Codecov Report

Merging #489 (e56da34) into main (d9bb181) will increase coverage by 0.02%.
The diff coverage is 86.70%.

@@             Coverage Diff              @@
##               main     #489      +/-   ##
============================================
+ Coverage     93.60%   93.62%   +0.02%     
+ Complexity     2712     2630      -82     
============================================
  Files           409      393      -16     
  Lines          6909     6665     -244     
  Branches        447      429      -18     
============================================
- Hits           6467     6240     -227     
+ Misses          255      252       -3     
+ Partials        187      173      -14     
Files Coverage Δ
src/main/java/com/vonage/client/BinaryRequest.java 100.00% <100.00%> (ø)
src/main/java/com/vonage/client/HttpWrapper.java 100.00% <ø> (ø)
...com/vonage/client/account/CreateSecretRequest.java 100.00% <ø> (ø)
.../com/vonage/client/account/FullPricingRequest.java 100.00% <ø> (ø)
...om/vonage/client/account/PrefixPricingRequest.java 100.00% <ø> (ø)
...java/com/vonage/client/account/PricingRequest.java 100.00% <ø> (ø)
.../java/com/vonage/client/account/SecretRequest.java 75.00% <ø> (ø)
...n/java/com/vonage/client/account/TopUpRequest.java 87.50% <ø> (ø)
...va/com/vonage/client/auth/SignatureAuthMethod.java 93.33% <ø> (-0.42%) ⬇️
...n/java/com/vonage/client/auth/TokenAuthMethod.java 88.23% <ø> (-0.66%) ⬇️
... and 23 more

... and 2 files with indirect coverage changes

@SMadani SMadani merged commit 8cfcf59 into main Oct 20, 2023
@SMadani SMadani deleted the proactive-connect branch October 20, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants