Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Endpoint types for Voice #446

Merged
merged 3 commits into from
Apr 11, 2023
Merged

Add missing Endpoint types for Voice #446

merged 3 commits into from
Apr 11, 2023

Conversation

SMadani
Copy link
Contributor

@SMadani SMadani commented Apr 6, 2023

Adds vbc and app endpoints for deserialisation and some cleanup around that area. See #443 for context.

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2023

Codecov Report

Merging #446 (0e22082) into main (2134ce0) will increase coverage by 0.06%.
The diff coverage is 52.94%.

@@             Coverage Diff              @@
##               main     #446      +/-   ##
============================================
+ Coverage     91.78%   91.84%   +0.06%     
- Complexity     1814     1837      +23     
============================================
  Files           305      308       +3     
  Lines          4869     4907      +38     
  Branches        226      225       -1     
============================================
+ Hits           4469     4507      +38     
- Misses          309      310       +1     
+ Partials         91       90       -1     
Impacted Files Coverage Δ
...java/com/vonage/client/voice/ncco/AppEndpoint.java 100.00% <ø> (ø)
...java/com/vonage/client/voice/ncco/VbcEndpoint.java 0.00% <0.00%> (ø)
...ava/com/vonage/client/voice/WebSocketEndpoint.java 55.55% <28.57%> (+55.55%) ⬆️
...main/java/com/vonage/client/voice/AppEndpoint.java 87.50% <87.50%> (ø)
...main/java/com/vonage/client/voice/VbcEndpoint.java 87.50% <87.50%> (ø)
src/main/java/com/vonage/client/voice/Call.java 96.77% <100.00%> (+0.05%) ⬆️
...in/java/com/vonage/client/voice/PhoneEndpoint.java 100.00% <100.00%> (+4.00%) ⬆️
...main/java/com/vonage/client/voice/SipEndpoint.java 90.00% <100.00%> (+90.00%) ⬆️

@SMadani SMadani marked this pull request as ready for review April 11, 2023 10:19
@SMadani SMadani mentioned this pull request Apr 11, 2023
3 tasks
@SMadani SMadani merged commit 2168439 into main Apr 11, 2023
@SMadani SMadani deleted the app-endpoint branch April 11, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants