Further encapsulate HttpClient internals

Vonage · May 22, 2024 · 8eb24a3 · 8eb24a3
1 parent 418a9e6
commit 8eb24a3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/main/java/com/vonage/client/AbstractMethod.java b/src/main/java/com/vonage/client/AbstractMethod.java
@@ -170,7 +170,7 @@ public String getApplicationIdOrApiKey() throws VonageUnexpectedException {
      *
      * @throws UnsupportedEncodingException if UTF-8 encoding is not supported by the JVM
      */
-    public abstract RequestBuilder makeRequest(RequestT request) throws UnsupportedEncodingException;
+    protected abstract RequestBuilder makeRequest(RequestT request) throws UnsupportedEncodingException;
 
     /**
      * Construct a ResultT representing the contents of the HTTP response returned from the Vonage Voice API.
@@ -181,5 +181,5 @@ public String getApplicationIdOrApiKey() throws VonageUnexpectedException {
      *
      * @throws IOException if a problem occurs parsing the response
      */
-    public abstract ResultT parseResponse(HttpResponse response) throws IOException;
+    protected abstract ResultT parseResponse(HttpResponse response) throws IOException;
 }
diff --git a/src/main/java/com/vonage/client/DynamicEndpoint.java b/src/main/java/com/vonage/client/DynamicEndpoint.java
@@ -182,7 +182,7 @@ else if (requestBody instanceof BinaryRequest) {
 	}
 
 	@Override
-	public final RequestBuilder makeRequest(T requestBody) {
+	protected final RequestBuilder makeRequest(T requestBody) {
 		if (requestBody instanceof Jsonable && responseType.isAssignableFrom(requestBody.getClass())) {
 			cachedRequestBody = requestBody;
 		}
@@ -227,7 +227,7 @@ else if (requestBody instanceof byte[]) {
 	}
 
 	@Override
-	public final R parseResponse(HttpResponse response) throws IOException {
+	protected final R parseResponse(HttpResponse response) throws IOException {
 		int statusCode = response.getStatusLine().getStatusCode();
 		try {
 			if (statusCode >= 200 && statusCode < 300) {