Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add unit component #54

Merged
merged 15 commits into from
Sep 6, 2024

Conversation

mengxi-ream
Copy link
Contributor

@mengxi-ream mengxi-ream commented Aug 22, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Update dependency
  • Code style optimization
  • Test Case
  • Branch merge
  • Site / documentation update
  • Demo update
  • Workflow
  • Release
  • Other (about what?)

🔗 Related issue link

🐞 Bugserver case id

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

@mengxi-ream mengxi-ream changed the title [WIP] feat: add unit component feat: add unit component Aug 27, 2024
@mengxi-ream
Copy link
Contributor Author

mengxi-ream commented Aug 27, 2024

@xiaoluoHe 这个 PR 好了,修复了昨天提到的问题
然后关于 pnpm 的 conflict,是不是我任意 solve conflict 就可以呢?因为我看 文档 里面写的是,merge 之后,pnpm install (我们应该就是 rush update?),然后 commit 一次就可以

这个项目需要写 changelog 吗?我看 ./docs/assets/changelog 是空的,好想之前都没写过?

@xiaoluoHe
Copy link
Contributor

@xiaoluoHe 这个 PR 好了,修复了昨天提到的问题 然后关于 pnpm 的 conflict,是不是我任意 solve conflict 就可以呢?因为我看 文档 里面写的是,merge 之后,pnpm install (我们应该就是 rush update?),然后 commit 一次就可以

这个项目需要写 changelog 吗?我看 ./docs/assets/changelog 是空的,好想之前都没写过?

lock 冲突了的话,重新 rush update 一下就可以

另外, VStory 还没有正式发版,changelog 可以先不写;

@xiaoluoHe xiaoluoHe merged commit 8579303 into VisActor:develop Sep 6, 2024
2 of 5 checks passed
@mengxi-ream
Copy link
Contributor Author

The math of auto layout algorithm: https://www.mengxi.work/blog/unit-viz-auto-layout-algo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants