Custom color for courses #391
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
NishchintDhawan
changed the title
NishchintDhawan
force-pushed
the
nishchint/custom-color-for-courses
branch
from
c07706c to
ddada51
Compare
A possible solution for the future is https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/color-contrast |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR provides the user to select a custom color for the courses currently selected. The current implementation provides a way to select a color from the provided list of colors which comes up when the user clicks on the edit icon.
Closes #361
Screenshots
After
When the user has clicked on the edit icon:
Dark mode:
Checklist
General Comments
The user interaction is not finalised but just one of the ways to solve the issue. Another option could be to provide custom colors. The issue with that is if the user chooses white or black as colors, the edit button might not be visible along with the room number. Open for discussion !