[Birthday] Add required role #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any idea when this will be merged? Or did you need someone like me to test it first. |
|
Yes I'll merge it when I get time to test it, or if you are happy to then test it let me know if it works and I'll merge it |
I tried to test it and failed. I don't know if my steps are wrong.
LogSep 25 00:43:18 : [2024-09-25 00:43:18] [ERROR] red: Package loading failed
Sep 25 00:43:18 : Traceback (most recent call last):
Sep 25 00:43:18 : File "/home/zoriot/redenv/lib/python3.11/site-packages/redbot/core/core_commands.py", line 189, in _load
Sep 25 00:43:18 : await bot.load_extension(spec)
Sep 25 00:43:18 : File "/home/zoriot/redenv/lib/python3.11/site-packages/redbot/core/bot.py", line 1684, in load_extension
Sep 25 00:43:18 : lib = spec.loader.load_module()
Sep 25 00:43:18 : ^^^^^^^^^^^^^^^^^^^^^^^^^
Sep 25 00:43:18 : File "<frozen importlib._bootstrap_external>", line 605, in _check_name_wrapper
Sep 25 00:43:18 : File "<frozen importlib._bootstrap_external>", line 1120, in load_module
Sep 25 00:43:18 : File "<frozen importlib._bootstrap_external>", line 945, in load_module
Sep 25 00:43:18 : File "<frozen importlib._bootstrap>", line 290, in _load_module_shim
Sep 25 00:43:18 : File "<frozen importlib._bootstrap>", line 721, in _load
Sep 25 00:43:18 : File "<frozen importlib._bootstrap>", line 690, in _load_unlocked
Sep 25 00:43:18 : File "<frozen importlib._bootstrap_external>", line 940, in exec_module
Sep 25 00:43:18 : File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
Sep 25 00:43:18 : File "/home/zoriot/.local/share/Red-DiscordBot/data/Zoto/cogs/CogManager/cogs/birthday/__init__.py", line 10, in <module>
Sep 25 00:43:18 : from .birthday import Birthday
Sep 25 00:43:18 : File "/home/zoriot/.local/share/Red-DiscordBot/data/Zoto/cogs/CogManager/cogs/birthday/birthday.py", line 11, in <module>
Sep 25 00:43:18 : from .commands import BirthdayAdminCommands, BirthdayCommands
Sep 25 00:43:18 : File "/home/zoriot/.local/share/Red-DiscordBot/data/Zoto/cogs/CogManager/cogs/birthday/commands.py", line 209, in <module>
Sep 25 00:43:18 : class BirthdayAdminCommands(MixinMeta):
Sep 25 00:43:18 : File "/home/zoriot/.local/share/Red-DiscordBot/data/Zoto/cogs/CogManager/cogs/birthday/commands.py", line 712, in BirthdayAdminCommands
Sep 25 00:43:18 : @bdset.command()
Sep 25 00:43:18 : ^^^^^^^^^^^^^^^
Sep 25 00:43:18 : File "/home/zoriot/redenv/lib/python3.11/site-packages/redbot/core/commands/commands.py", line 711, in decorator
Sep 25 00:43:18 : result = command(*args, **kwargs)(func)
Sep 25 00:43:18 : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Sep 25 00:43:18 : File "/home/zoriot/redenv/lib/python3.11/site-packages/discord/ext/commands/core.py", line 1792, in decorator
Sep 25 00:43:18 : raise TypeError('Callback is already a command.')
Sep 25 00:43:18 : TypeError: Callback is already a command.
|
|
I'll look later, thanks for taking the time to test. |
|
The problems seems to be fixed with that changes fc6ebc1. You can commit that to this branch, if you like. |
|
Thank you for taking the time to test this and the commit to fix it. |
|
I didn't know if I should open a new issue for this but people without the required role still show up in the "upcoming" command, and I feel like that shouldn't be the case |
|
This doesn't appear to be working for me, people without the set role are still getting pinged on their birthday |
|
I'll take a look at some point. Thanks for letting me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a required role that users need to have to be able to add their birthday and have it announced.
Closes #133
Currently untested