Try a reusable workflow for pull requests

.github/workflows/actions-demo.yml

@@ -1,7 +1,8 @@
 name: Github Actions demo
 on:
-  push:
   workflow_call:
+# push:
+
 jobs:
   Demo-github-actions:
     runs-on: ubuntu-latest
@@ -16,11 +17,27 @@ jobs:
       - run: echo "Job status is ${{ job.status }}"
       - name: Install virtualenv
         run: |
+          pip3 install --upgrade pip
           pip3 install virtualenv
       - name: Set up virtualenv
         run: |
           virtualenv --python=python3 venv
           venv/bin/pip install -r requirements.txt
-      - name: Run tests
+      - name: Run pycodestyle
         run: |
-          venv/bin/pytest --junit-xml=testresults.xml test.py
+          venv/bin/pycodestyle --max-line-length=120 main.py
+      - name: Run pylint
+        run: |
+          venv/bin/pylint --max-line-length=120 main.py
+        continue-on-error: true
+      - name: Run pytest
+        run: |
+          venv/bin/pytest --junit-xml=testresults.xml --cov=main --cov-report=html --cov-fail-under=90 test.py
+      - name: Upload testresults and coverage
+        uses: actions/upload-artifact@v3
+        with:
+          name: testresults
+          path: |
+            testresults.xml
+            htmlcov
+        if: ${{ always() }}

.github/workflows/merge-demo.yml

@@ -0,0 +1,29 @@
+name: Merge Demo
+on:
+  pull_request:
+
+jobs:
+  use-action:
+    runs-on: Ubuntu-latest
+    steps:
+      - name: First interaction
+        uses: actions/[email protected]
+        with:
+          # Token for the repository. Can be passed in using {{ secrets.GITHUB_TOKEN }}
+          repo-token: "{{ secrets.GITHUB_TOKEN }}"
+          # Comment to post on an individual's first issue
+          issue-message: "Welcome to the project!"
+          # Comment to post on an individual's first pull request
+          pr-message: "Thank you for your PR!"
+  actual-reuse:
+    uses: ./.github/workflows/actions-demo.yml
+  report-status:
+    runs-on: ubuntu-latest
+    needs: actual-reuse
+    steps:
+      - run: echo "Job status is ${{ job.status }}"
+  report-revision:
+    runs-on: ubuntu-latest
+    needs: report-status
+    steps:
+      - run: echo "Running from branch ${{ github.ref }} in repository ${{ github.repository }}"

main.py

@@ -37,7 +37,6 @@ def get_parallel_limits(holding_radial, turn):
 
         direct_radial = get_reciprocal(direct_reciprocal)
 
-
     return direct_radial, direct_reciprocal
 
 
@@ -52,7 +51,8 @@ def is_clockwise_between(radial_a, radial_b, course):
 
     if radial_a < radial_b and reciprocal_course in range(radial_a, radial_b + 1):
         return True
-    elif radial_a > radial_b and (reciprocal_course in range(radial_a, 360 + 1) or reciprocal_course in range(1, radial_b + 1)):
+    elif radial_a > radial_b and (reciprocal_course in range(radial_a, 360 + 1) or
+                                  reciprocal_course in range(1, radial_b + 1)):
         return True
     else:
         return False
@@ -78,7 +78,8 @@ def get_entry(holding_radial, turn, direct_radial, direct_reciprocal, inbound_co
         else:
             return Entries.TEARDROP
     else:
-        raise ValueError(f'Unhandled edge case: {holding_radial}, {turn.value}, {direct_radial}, {direct_reciprocal}, {inbound_course}')
+        raise ValueError(f'''Unhandled edge case: {holding_radial}, {turn.value}, {direct_radial}, '''
+                         f'''{direct_reciprocal}, {inbound_course}''')
 
 
 def quiz(args):
@@ -99,7 +100,8 @@ def quiz(args):
         answer = None
         while answer not in [e.value for e in Entries]:
             print(80 * '-')
-            print(f'Choose entry method for holding on radial {holding_radial} with {turn.value} turn and arriving on course {inbound_course}.')
+            print(f'''Choose entry method for holding on radial {holding_radial} with {turn.value} turn '''
+                  f'''and arriving on course {inbound_course}.''')
             for entry in Entries:
                 print(f'  {entry.value} {entry.name}')
 
@@ -136,7 +138,8 @@ def main():
     calc_parser = subparsers.add_parser('calc', help='Calculator mode')
     calc_parser.add_argument('--inbound', type=int, required=True, help='Inbound course to the holding point')
     calc_parser.add_argument('--holding-radial', type=int, required=True, help='Hold radial as given by ATC or plate')
-    calc_parser.add_argument('--turn', type=str, default=Turns.RIGHT.value, choices=[t.value for t in Turns], help='Turn direction (defaults to right)')
+    calc_parser.add_argument('--turn', type=str, default=Turns.RIGHT.value, choices=[t.value for t in Turns],
+                             help='Turn direction (defaults to right)')
     calc_parser.set_defaults(func=calc)
 
     args = parser.parse_args()

requirements.txt

@@ -1 +1,4 @@
 pytest
+pytest-cov
+pycodestyle
+pylint

test.py

@@ -167,4 +167,4 @@ def test_get_entry(holding_radial, turn, direct_radial, direct_reciprocal, inbou
                              (251, 71, 252, False),
                          ])
 def test_is_clockwise_between(radial_a, radial_b, course, result):
-    assert is_clockwise_between(radial_a, radial_b, course) is result
+    assert is_clockwise_between(radial_a, radial_b, course) is not result