Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix segfault on pulseaudio; allow linking by pid/proc binary #6

Merged
merged 11 commits into from
Oct 14, 2023
Merged

Fix segfault on pulseaudio; allow linking by pid/proc binary #6

merged 11 commits into from
Oct 14, 2023

Conversation

Curve
Copy link
Member

@Curve Curve commented Oct 14, 2023

  • Detect if user is not running pipewire as main audio server
  • Work with raw pipewire props to link / list

Resolves #4

This time properly rebased lmao

@Curve Curve requested a review from Vendicated October 14, 2023 14:00
Vendicated
Vendicated reviewed Oct 14, 2023
View reviewed changes
lib/module.d.ts Outdated Show resolved Hide resolved
@Curve Curve requested a review from Vendicated October 14, 2023 14:19
@Vendicated Vendicated changed the title alternative pulse-fix and alternative link approach Fix segfault on pulseaudio; allow linking by pid/proc binary Oct 14, 2023
@Vendicated Vendicated merged commit ccd3e64 into main Oct 14, 2023
10 checks passed
@Vendicated Vendicated deleted the pulse-fix-and-improvement-fixed branch October 14, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vendicated Vendicated Vendicated approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Curve @Vendicated