Small update to FLamby install instructions to avoid cluster failures. #287
Conversation
| @@ -17,8 +17,10 @@ cd <fl4health_repository> | |||
| pip install --upgrade pip poetry | |||
| poetry install --with "dev, dev-local, test, codestyle" | |||
| cd <FLamby_repository> | |||
| pip install albumentations==1.4.20 | |||
There was a problem hiding this comment.
Shouldn't we add this to poetry's pyproject.toml instead?
There was a problem hiding this comment.
Good question. This is specific to the FLamby environment. We don't use albumentations in our library but FLamby does in theirs. There is an issue using the most recent version of the library though. So this forces a pin while still allowing the rest of FLamby's dependencies to be installed
There was a problem hiding this comment.
I see. Is that the only dependency that is in flamby but not in fl4health?
There was a problem hiding this comment.
No. Unfortunately there are a lot more in FLamby that are necessary to support the different datasets.
There was a problem hiding this comment.
I see, I was just wondering if there was a requirements file somewhere that you could put this but looking into it here it seems like there isn't, so all good.
There was a problem hiding this comment.
Your thought process is a good one. We actually used to have a requirements file for installing the requirements of FL4Health and FLamby together. The problem was that it ends up out of date fairly quickly, as it's not tied to our poetry or their repository. If you have better suggestions for maintaining the compatibility as a follow up PR, I'm open to it 🙂
PR Type
Documentation
Short Description
Albumentations upgraded to 1.4.21 on October 31st. They now rely on simsimd, which is not compatible with our cluster. So we pin to 1.4.20 to make stuff work.