Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove timeout logic #441

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Remove timeout logic #441

merged 2 commits into from
Jan 13, 2025

Conversation

pasha-nikitin-2003
Copy link
Contributor

Фикс routerNavigator.runSync

  • Убрали зависимость от непредсказуемой логики timeout
  • Заменили код перехода из Alert, в примере приложения

@pasha-nikitin-2003 pasha-nikitin-2003 requested a review from a team as a code owner December 23, 2024 00:59
nshvyryaev
nshvyryaev previously approved these changes Dec 23, 2024
View reviewed changes
@pasha-nikitin-2003
Copy link
Contributor Author

pasha-nikitin-2003 commented Dec 23, 2024 •
edited
Loading

Не вливать, пока не поднимем версию библиотеки до 1.7.2 в примере.

@pasha-nikitin-2003 pasha-nikitin-2003 force-pushed the pavelnikitin/fix/popout-alert-example branch from 3046570 to 33eab2f Compare January 13, 2025 14:34
@pasha-nikitin-2003 pasha-nikitin-2003 merged commit bebf5da into master Jan 13, 2025
1 check passed
@pasha-nikitin-2003 pasha-nikitin-2003 deleted the pavelnikitin/fix/popout-alert-example branch January 13, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pajecawav-vk pajecawav-vk pajecawav-vk approved these changes

@nshvyryaev nshvyryaev nshvyryaev left review comments

Assignees
No one assigned
Labels
pay attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pasha-nikitin-2003 @nshvyryaev @pajecawav-vk @vkcom-publisher @pavel-nikitin-2022 @actions-user