MA-19935: Implement history-less modal close #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nshvyryaev
reviewed
Oct 29, 2024
pasha-nikitin-2003
force-pushed
the
pavelnikitin/feature/modal-close-no-history/MA-19935
branch
from
342b472 to
48199af
Compare
nshvyryaev
previously approved these changes
Oct 29, 2024
pasha-nikitin-2003
force-pushed
the
pavelnikitin/feature/modal-close-no-history/MA-19935
branch
from
f90220c to
ca4ca71
Compare
pajecawav-vk
approved these changes
Oct 30, 2024
pasha-nikitin-2003
added a commit
that referenced
this pull request
Nov 7, 2024
…o-history/MA-19935 MA-19935: Implement history-less modal close
pasha-nikitin-2003
added a commit
that referenced
this pull request
Nov 7, 2024
…o-history/MA-19935 MA-19935: Implement history-less modal close
pasha-nikitin-2003
deleted the
pavelnikitin/feature/modal-close-no-history/MA-19935
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
routeNavigator.hideModal(false, {replacePanel: true})}- если история переходов пуста, то новая запись не будет добавлена. Можно использовать следующий вариант:routeNavigator.hideModal(true)- всегда закрываем модальную страницу с добавлением позиции в историюrouteNavigator.hideModal(true, {replacePanel: true}))- всегда закрываем модальную страницу через replace, плохая практика, так как при закрытии модальной страницы, будет сохраняться дубликат предыдущей записи.