added additional instance cache metric #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troy4eg
force-pushed
the
troy4eg/extended_instance_cache_metrics
branch
2 times, most recently
from
a026966 to
298ac75
Compare
DrDet
reviewed
Nov 2, 2023
troy4eg
force-pushed
the
troy4eg/extended_instance_cache_metrics
branch
12 times, most recently
from
c890694 to
82d89dc
Compare
troy4eg
force-pushed
the
troy4eg/extended_instance_cache_metrics
branch
3 times, most recently
from
2ee4402 to
8346d21
Compare
troy4eg
force-pushed
the
troy4eg/extended_instance_cache_metrics
branch
from
8346d21 to
d20586b
Compare
DrDet
reviewed
Nov 8, 2023
DrDet
previously approved these changes
Nov 8, 2023
troy4eg
force-pushed
the
troy4eg/extended_instance_cache_metrics
branch
from
c075162 to
a09d89e
Compare
DrDet
previously approved these changes
Nov 8, 2023
troy4eg
force-pushed
the
troy4eg/extended_instance_cache_metrics
branch
from
3c18b6a to
7a5edae
Compare
DrDet
approved these changes
Nov 8, 2023
astrophysik
pushed a commit
that referenced
this pull request
Nov 9, 2023
added additional instance cache 'kphp_instance_cache_data_size' metric
astrophysik
added a commit
that referenced
this pull request
Nov 9, 2023
This reverts commit 14f4a7d.
Danil42Russia
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added metric to track the amount of memory that is used for the store instance to instance cache