fix(CustomSelect): auto scroll only on open #8173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
patch
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8173 +/- ##
=======================================
Coverage 95.49% 95.49%
=======================================
Files 403 403
Lines 11456 11462 +6
Branches 3781 3784 +3
=======================================
+ Hits 10940 10946 +6
Misses 516 516
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BlackySoul
force-pushed
the
blackysoul/fix_customselect_auto_scroll
branch
from
5d4e0d5 to
9c59ac6
Compare
e2e tests |
SevereCloud
approved these changes
Jan 23, 2025
EldarMuhamethanov
approved these changes
Jan 23, 2025
👀 Docs deployed
Commit 9c59ac6 |
BlackySoul
removed
the
patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Дано - селект, в который по какому-то условию подгружаются опции (например, когда долистали до конца списка).
В чем проблема? Сейчас мы делаем скролл к выбранной опции внутри
ref-callback, который вdepsимеет фунцию, которая зависит отoptions.length, соответственноref-callbackвызывается каждый раз, как меняется количество опций и происходит скролл к выбранному элементу.Изменения
Оставляем
ref-callbackбез зависимостей и уносим из него установку скролла (ещё это потенциально улучшит потребление памяти).Установку скролла делаем в
useIsomorphicLayoutEffect, ориентируясь наref-переменнуюscrollPerformedRef.Release notes