Ik modifier 3d qcp #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire
force-pushed
the
ik-modifier-3d-qcp
branch
24 times, most recently
from
19eaa89 to
da2fae9
Compare
fire
commented
Jan 21, 2025
fire
commented
Jan 21, 2025
fire
force-pushed
the
ik-modifier-3d-qcp
branch
7 times, most recently
from
2eba574 to
00df9e2
Compare
shakesoda
reviewed
Jan 22, 2025
shakesoda
reviewed
Jan 22, 2025
scene/3d/fabr_ik_3d.cpp
Outdated
| @@ -76,8 +76,7 @@ void FABRIK3D::_process_joints(double p_delta, Skeleton3D *p_skeleton, Vector<Ma | |||
|
|
|||
| // Forwards. | |||
| for (int i = 0; i < p_joints.size(); i++) { | |||
| // TODO: coding which is similer to above backwards moving. | |||
| // TODO: coding which is similar to above backwards moving. | |||
There was a problem hiding this comment.
whole loop is just this todo (the spellcheck is an improvement at least)
fire
force-pushed
the
ik-modifier-3d-qcp
branch
3 times, most recently
from
ba0e284 to
fe045b5
Compare
TokageItLab
force-pushed
the
ik-modifier-3d
branch
2 times, most recently
from
efe204c to
df51a9f
Compare
fire
force-pushed
the
ik-modifier-3d-qcp
branch
4 times, most recently
from
c0c9790 to
ccef558
Compare
|
Restored the old root transform solve. Still working on the rotation. |
fire
force-pushed
the
ik-modifier-3d-qcp
branch
from
ccef558 to
afd090f
Compare
|
Pause for now. Doesn't seem to get the node path's rotation. Also which setting element? |
fire
force-pushed
the
ik-modifier-3d-qcp
branch
5 times, most recently
from
b3dd26d to
abe3c0c
Compare
|
I removed all the code for the rotation as it wasn't doing anything. Revisit sometime in the future. |
Add some documentation. Add validation for joint settings and implement rootmost bone check Fix rootmost bone validation and adjust bone chain transformation logic Refactor joint processing logic to improve clarity and efficiency Fix comments for clarity and adjust bone translation logic in CCDIK3D Refactor CCDIK3D joint processing by removing unused rotation calculations
fire
force-pushed
the
ik-modifier-3d-qcp
branch
from
abe3c0c to
f23f7f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For review.