Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yda-6102: refactor csv import in group manager module #546

Merged
merged 6 commits into from
Jan 29, 2025
Merged

Yda-6102: refactor csv import in group manager module #546

merged 6 commits into from
Jan 29, 2025

Conversation

leonidastri
Copy link
Contributor

This is a refactor of csv parsing in Group Manager.

  • Replaced custom CSV parsing logic in Group Manager with Python's built-in csv library.
  • Resolves the issue where commas in column values caused parsing errors by leveraging the library's robust handling of CSV format.

@lwesterhof lwesterhof self-requested a review January 29, 2025 10:22
lwesterhof
lwesterhof approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@lwesterhof lwesterhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lwesterhof lwesterhof merged commit e6e5fdf into development Jan 29, 2025
7 of 8 checks passed
@lwesterhof lwesterhof deleted the YDA-6102-csv-import-parse branch January 29, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwesterhof lwesterhof lwesterhof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leonidastri @lwesterhof