Improve validation of OAuth tokens (#189)

* Extra validation of oauth tokens * Also update the backend readme * Also use bookworm-slim in runtime container * Ensure consistent kebab-case * Handle request failures without leaking implementation details --------- Co-authored-by: Micah <[email protected]>
UpliftGames · Oct 21, 2024 · 5317c25 · 5317c25
1 parent ea536c5
commit 5317c25
Show file tree

Hide file tree

Showing 8 changed files with 147 additions and 44 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -58,6 +58,7 @@ ubyte = "0.10.3"
 indicatif = "0.17.4"
 tokio = "1.28.2"
 serial_test = "2.0.0"
+time = "=0.3.35"
 
 [dev-dependencies]
 insta = { version = "1.1.0" }

diff --git a/README.md b/README.md
@@ -53,7 +53,7 @@ Pre-built binaries are available for Windows, macOS, and Linux from the [GitHub
 [releases]: https://github.com/UpliftGames/wally/releases
 
 ### From Source
-It's straightforward to compile Wally from source. Wally requires Rust 1.51.0 or newer.
+It's straightforward to compile Wally from source. Wally requires Rust 1.80.0 or newer.
 
 Clone the repository and use:
 

diff --git a/wally-registry-backend/Cargo.toml b/wally-registry-backend/Cargo.toml
@@ -37,6 +37,7 @@ url = { version = "2.2.1", features = ["serde"] }
 walkdir = "2.3.1"
 zip = "0.5.11"
 moka = "0.11.1"
+time = "=0.3.35"
 
 [dev-dependencies]
 tempfile = "3.1.0"

diff --git a/wally-registry-backend/Dockerfile b/wally-registry-backend/Dockerfile
@@ -1,4 +1,4 @@
-FROM rust:1-slim-buster AS build
+FROM rust:1.81-slim-bookworm AS build
 WORKDIR /usr/app
 
 # Debian Slim doesn't install certificates by default, but we kinda want those.
@@ -24,7 +24,7 @@ COPY ./wally-registry-backend ./wally-registry-backend/
 RUN touch wally-registry-backend/src/main.rs
 RUN cargo build --package wally-registry-backend --release
 
-FROM debian:buster-slim
+FROM debian:bookworm-slim
 
 # Install the same SSL packages as in our build image.
 RUN apt-get update

diff --git a/wally-registry-backend/README.md b/wally-registry-backend/README.md
@@ -2,7 +2,7 @@
 This directory contains the backend to the Wally registry. It's the interface that clients use for downloading, publishing, and yanking packages.
 
 ## Requirements
-- Rust 1.50.0+
+- Rust 1.80.0+
 - C toolchain for OpenSSL
 
 ## Running