Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GUI): Add settings for theme, fiat currency and remote nodes #128

Merged
merged 39 commits into from
Nov 13, 2024

Conversation

Einliterflasche
Copy link

@Einliterflasche Einliterflasche commented Oct 25, 2024

Add light and darker themes, better ui for custom nodes, support for other currencies. Closes #14

@binarybaron
Copy link

binarybaron commented Oct 25, 2024

You accidentally created the branch from the libp2p upgrade one (instead of from master). You can copy the hashes of the commits, reset your branch using --hard to origin/master and git cherry-pick your commits. There's probably a better way but that'd work.

@Einliterflasche
Copy link
Author

No, that was on purpose because master was crashing due to incorrect usage of unsafe code. I'll do that before we merge

@Einliterflasche
Copy link
Author

Einliterflasche commented Nov 6, 2024

currently the monero-daemon doesn't get started... There's some issue with the new MoneroDaemon struct

@Einliterflasche
Copy link
Author

Ok that is fixed. However, I think the settings aren't getting properly persisted.

@Einliterflasche
Copy link
Author

Currently getting this error, I just can't figure out why

ERROR Failed to initialize context error=Failed to initialize Bitcoin wallet

Caused by:
    0: Failed to subscribe to header notifications
    1: Made one or multiple attempts, all errored:
        - invalid peer certificate contents: invalid peer certificate: CertExpired
        - invalid peer certificate contents: invalid peer certificate: CertExpired
        - invalid peer certificate contents: invalid peer certificate: CertExpired
        - invalid peer certificate contents: invalid peer certificate: CertExpired
        - invalid peer certificate contents: invalid peer certificate: CertExpired

yesterday it didn't work either on libp2p/upgrade, though now it works there on not on this branch

@binarybaron
Copy link

You can rebase this on master

@binarybaron
Copy link

binarybaron commented Nov 12, 2024

A few comments:

  1. You can remove the calls to updateAllNodeStatuses from the React components and move it to src-gui/src/store/middleware/storeListener.ts. You can also check the status of a single node when it is first added. (Read this)
  2. You can add empty nodes (empty string). Should be validated before.
  3. There's a bug where when you change the priority of a node there's some sort of infinit loop where the nodes keep switching places

@binarybaron
Copy link

fyi you probably didn't pull before rebasing

@Einliterflasche
Copy link
Author

Nooooooooooooooooo

* feat(gui): Allow user to select from recently used monero addresses in textfield
The Github documentation has been moved from /docs to /dev-docs

Closes #129
We no longer show the manual cancel and refund button. This functionality is currently not implemented in the GUI. The state machine should resume the swap as well. The functionality can be added back later.
binarybaron and others added 14 commits November 13, 2024 10:09
…109)

Our libp2p version is out of date, and we need to tackle the upgrade even though it's a significant undertaking. This'll also fix some other [issues](#95).

- Breaking network protocol change: The libp2p version has been upgraded to 0.53 which includes breaking network protocol changes. ASBs and CLIs will not be able to swap if one of them is on the old version.
- ASB: Transfer proofs will be repeatedly sent until they are acknowledged by the other party. This fixes a bug where it'd seem to Bob as if the Alice never locked the Monero. Forcing the swap to be refunded.
- CLI: Encrypted signatures will be repeatedly sent until they are acknowledged by the other party
- CLI+ASB: Libp2p network errors in request-response protocols are now propagated throught the event loop channels. This allows the caller to retry if an error occurs (e.g timeout)

Closes #101, #95
…ing on �[?1049h�[>4;2m�[?1h�=�[?2004h�[?1004h�[1;11r�[?12h�[?12l�[22;2t�[22;1t�[27m�[23m�[29m�[m�[H�[2J�[?25l�[11;1H"logs" [New]�[2;1H�[94m~ �[3;1H~ �[4;1H~ �[5;1H~ �[6;1H~ �[7;1H~ �[8;1H~ �[9;1H~ �[10;1H~ �[1;1H�[?25h�[?4m�[11;1H�[?2004l�[>4;m�[23;2t�[23;1t�[m�[11;1H�[K�[11;1H�[?1004l�[?2004l�[?1l�>�[?1049l�[>4;m
@Einliterflasche Einliterflasche marked this pull request as ready for review November 13, 2024 20:52
@Einliterflasche Einliterflasche changed the title feat(GUI): add preferences ui feat(GUI): add settings for theme, currency and custom remote nodes Nov 13, 2024
@binarybaron binarybaron changed the title feat(GUI): add settings for theme, currency and custom remote nodes feat(GUI): Add settings for theme, fiat currency and remote nodes Nov 13, 2024
@binarybaron binarybaron merged commit 3e79bb3 into master Nov 13, 2024
26 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement preferences for controlling app behaviour
2 participants