Switch isAlive to be connection status #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fabio1988
approved these changes
Nov 13, 2024
Fabio1988
force-pushed
the
isAliveToConnectionStatus
branch
from
e0939bd to
87c6a47
Compare
|
Thanks for bringing this up, I like this solution way more :) |
Fabio1988
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes isAlive to be a connection status (ie set to false only on disconnection)
The previous isAlive is renamed to heartbeatCheckStatus - this status indicates that a pong is outstanding, and has not very much use externally (though was used before and confused people)