Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arm64 docker image publish #42

Merged
merged 1 commit into from
Sep 22, 2024
Merged

Conversation

FabianTerhorst
Copy link
Contributor

I have noticed the docker image is only published for the amd64 platform. Publishing to arm64 should work as well, because gcr.io/distroless/nodejs:18 also has arm64 in its manifest.

@Fabio1988
Copy link
Contributor

Thanks for PR :)

This doesn't work out of out box like that, it needs QEMU to emulate platform :)
Checkout golbat workflow, it's just one-two lines missing:)

@FabianTerhorst
Copy link
Contributor Author

Thanks for PR :)

This doesn't work out of out box like that, it needs QEMU to emulate platform :) Checkout golbat workflow, it's just one-two lines missing:)

Nice, thanks for the tip.

@jfberry
Copy link
Contributor

jfberry commented Sep 8, 2024

Never tried it but is that the case? Since node is interpreted perhaps it doesn’t. Maybe it needs it to run npm if that is part of the build

@Fabio1988 Fabio1988 requested a review from na-ji September 8, 2024 12:44
@Fabio1988 Fabio1988 merged commit 11278cd into UnownHash:main Sep 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants