Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #80: Stop client on unmount #81

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Fix #80: Stop client on unmount #81

merged 1 commit into from
Oct 5, 2022

Conversation

melloware
Copy link
Contributor

@melloware melloware commented Sep 23, 2022 •
edited
Loading

Fix #80: Stop client on unmount

  • Handles defensively stopping the client first in case someone passed in a started client for some reason
  • On Unmount will stop the client and null out the ref

@melloware melloware mentioned this pull request Sep 24, 2022
Closed
FredrikOseberg
FredrikOseberg approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@FredrikOseberg FredrikOseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this! LGTM

@FredrikOseberg
Copy link
Contributor

@melloware Could you make sure the tests pass also?

@melloware
Copy link
Contributor Author

Sure thing. Sorry about that I just ran yarn build only i will fix the tests.

@melloware
Copy link
Contributor Author

OK unit tests fixed.

@melloware
Copy link
Contributor Author

@FredrikOseberg any update?

@FredrikOseberg
Copy link
Contributor

FredrikOseberg commented Oct 5, 2022 •
edited
Loading

@FredrikOseberg any update?

Thanks for the reminder!

@FredrikOseberg FredrikOseberg merged commit 1d8344b into Unleash:main Oct 5, 2022
@melloware melloware deleted the ISSUE80 branch October 5, 2022 12:33
@nunogois nunogois mentioned this pull request Oct 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FredrikOseberg FredrikOseberg FredrikOseberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

React 18 Strict Mode
2 participants
@melloware @FredrikOseberg