Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow topologySpreadConstraints for unleash #158

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

pvickery-ParamountCommerce
Copy link
Contributor

About the changes

Adds support for topologySpreadConstraints to the unleash chart. This was copied from the unleash-edge helm chart

@chriswk
Copy link
Member

chriswk commented Jul 24, 2024

Hi @pvickery-ParamountCommerce - Thanks for your contribution. It's going to fail our checks, could I trouble you to bump the patch version inside Chart.yaml by one, so that I can merge and release this?

@chriswk chriswk self-assigned this Jul 24, 2024
Copy link
Member

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!

Thanks so much for your contribution.

We need a patch bump inside Chart.yaml to successfully pass our tests; once that's in place I'll approve and merge this

@pvickery-ParamountCommerce
Copy link
Contributor Author

Hi!

Thanks so much for your contribution.

We need a patch bump inside Chart.yaml to successfully pass our tests; once that's in place I'll approve and merge this

Thanks! I've bumped the version and applied the change to unleash-proxy as well. I also reset and squashed my changes for a cleaner commit history

@pvickery-ParamountCommerce
Copy link
Contributor Author

Hey @chriswk, could you give this a review when you have a sec? Thanks!

@chriswk
Copy link
Member

chriswk commented Jul 30, 2024

again, thank you, sorry for the late response. This got away from me. Will merge today

@chriswk chriswk merged commit 68731b8 into Unleash:main Jul 30, 2024
7 of 11 checks passed
@pvickery-ParamountCommerce
Copy link
Contributor Author

again, thank you, sorry for the late response. This got away from me. Will merge today

Thanks Chris! and no worries 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants