-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #166 On Unix-like OS, use unsafePerformIO (lookupEnv "TERM")
#167
Conversation
36dd36f
to
23e0edf
Compare
There is also |
(As I said in #150 (comment), I think we should just define |
@Bodigrim, on foreign import ccall unsafe "__hscore_environ"
getEnvBlock :: IO (Ptr CString) Is that also problematic? |
I think so. The C definition is #if !HAVE_DECL_ENVIRON
extern char** environ;
#endif
INLINE char **__hscore_environ(void) { return environ; } Now if one thread got Quoting Setenv is not Thread Safe:
|
@Bodigrim, now with the same approach to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Relying on CI to test.