Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix path finder #714

Merged
merged 160 commits into from
Jan 9, 2025
Merged

Fix path finder #714

merged 160 commits into from
Jan 9, 2025

Conversation

nicolas-f
Copy link
Member

@nicolas-f nicolas-f commented Nov 29, 2024 •
edited
Loading

Description

Fix reflection issues
Rework of pathfinder, more Cnossos test case are passing now
Re-enable and fix for NoiseModelling running with PostGIS as database instead of H2GIS

  • Move Cnossos attenuation code into propagation package. Pathfinder should compute only the vertical cut planes.
  • Unit test in pathfinder check only CutPlanes objects in geojson (expected test cases geojson stored into main ressources)
  • Unit test in propagation is using CutPlanes of pathfinder ressources to compute and check attenuation.
  • Generate report of cnossos test cases into the sphynx documentation (not in unit test)

Linked issues

#656

Remaining TODOs

Checklist

  • Code compiles correctly on all platforms
  • All pre-existing tests are passing
  • If needed, new tests have been added
  • Extended the README / documentation if necessary
  • Added code has been documented

nicolas-f and others added 30 commits October 7, 2024 15:32
@nicolas-f
add test for reflexion using issue
f7f915b
@nicolas-f
enhance test
f7f41a5
@nicolas-f
projection cones where filtered out by checking other walls of the sa…
068849a 
…me main polygon
@nicolas-f
advanced export of projection cones, with reflection order recursive
ef28e52
@nicolas-f
fix image source fetching
70e8250
@Adrien-lb
Correction Impact Noise / Calcul / Test
51b7a64
@MaguetteD
Update Create_Isosurface.groovy
b3dbbd5
@nicolas-f
fix reflection code. Complete unit test with second order reflection.
27e2d38
@nicolas-f
artifact v4
aa22a02
@Adrien-lb
edit Cl.yml version :
24db249 
v2 -> v4
@nicolas-f
fix interpolation and normalize inserted polygons (this operation was…
d0cc5d8 
… removed from a point of time?)
@nicolas-f
updated fields
94a1667
@nicolas-f
Revert "Update Create_Isosurface.groovy"
2eaecf0 
This reverts commit b3dbbd5.
@nicolas-f
upload v4 again
f79593a
@nicolas-f
Merge pull request #692 from Universite-Gustave-Eiffel/fix_revert
402779a 
Revert "Update Create_Isosurface.groovy"
@nicolas-f
Merge remote-tracking branch 'origin/4.X' into fixReflection
2f5c361
@nicolas-f
check reflection with a DEM at 500m
041385c
@nicolas-f
rename attribute
a53b819
@nicolas-f
update json test
e46a27e
@nicolas-f
Merge remote-tracking branch 'origin/fixReflection' into fixReflection5X
0bc9f87 
# Conflicts:
#	noisemodelling-pathfinder/src/main/java/org/noise_planet/noisemodelling/pathfinder/MirrorReceiverResult.java
#	noisemodelling-pathfinder/src/main/java/org/noise_planet/noisemodelling/pathfinder/MirrorReceiverResultIndex.java
#	noisemodelling-pathfinder/src/main/java/org/noise_planet/noisemodelling/pathfinder/PathFinder.java
#	noisemodelling-pathfinder/src/main/java/org/noise_planet/noisemodelling/pathfinder/profilebuilder/ProfileBuilder.java
#	noisemodelling-pathfinder/src/test/java/org/noise_planet/noisemodelling/pathfinder/TestWallReflection.java
#	noisemodelling-propagation/src/main/java/org/noise_planet/noisemodelling/propagation/cnossos/AttenuationCnossos.java
@nicolas-f
merge refl fix
49b57e7
@nicolas-f
fix building Z
4b74a73
@nicolas-f
fix xml version, export raypath
cd8e752
@nicolas-f
add altered version of cnossos result
381d92c
@nicolas-f
export all paths
03cfe1a
@nicolas-f
good? path
5d259be
@nicolas-f
reformated
16789ed
@nicolas-f
refactoring of get profile (fix, simplification, clarity, performance)
4174cef
@nicolas-f
fetch ground coefficient
3241a17
@nicolas-f
TC11 pass
2c314ef
nicolas-f and others added 27 commits December 9, 2024 12:02
@nicolas-f
Fix code scrambled by refactoring 3
ddb47d3
@nicolas-f
begining test with reference json documents
f762af1
@nicolas-f
fix json deserialization
dbc0a30
@nicolas-f
move pathfinder test to AttenuationCnossosTest
aad2eb9
@nicolas-f
complete pathfinder test with json
d56904a
@nicolas-f
complete pathfinder test with json
f170e13
@nicolas-f
fix code, now need to remove duplicate points from CutProfile and mov…
d25636c 
…e it to computePtsGround
@nicolas-f
insert primary key in cut profile for wall and buildings
3e4a506
@nicolas-f
save wall/building primary key
1fa1e7f
@nicolas-f
do not duplicate wall and reflection point anymore
dac6271
@nicolas-f
simplify function signature
7506f38
@nicolas-f
fix zGround conversion
2ba6b9b
@nicolas-f
fix attenuation
b0f1538
@nicolas-f
fix rayleigh
410f479
@nicolas-f
attenuation cnossos test ok
acd21c9
@nicolas-f
attenuation cnossos test ok, fix pk and index
ab7ef91
@nicolas-f
test default state
322c927
@nicolas-f
Fix failed merge with geometry in output tables
3569a70
@nicolas-f
fix coordinate and srid in output tables
1ae408e
@nicolas-f
always fetch srid in NoiseMapMaker
2b38db9
@nicolas-f
do not look for path in the unit test of attenuation computation, use…
be6347b 
… only generated json vertical profiles
@nicolas-f
prepare file for deviation computation from cnossos tests
04005aa
@nicolas-f
read json and evaluate attenuation
30c6104
@nicolas-f
generate main report table
650b0bf
@nicolas-f
generate main report table in single file
baebfce
@nicolas-f
fix doc gen
f19d000
@nicolas-f
generate final document, readthedocs can't run the compilation of jav…
471244e 
…a program so we have to commit generated rst source doc..
@nicolas-f nicolas-f marked this pull request as ready for review January 9, 2025 09:04
@nicolas-f nicolas-f merged commit 89e52e8 into 5.X Jan 9, 2025
2 checks passed
@nicolas-f nicolas-f deleted the fixReflection5X branch January 9, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-f @Adrien-lb @MaguetteD