-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GZ Docs #35
GZ Docs #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also add an installation page? The README covers that already, so I would be fine with skipping it...
Co-authored-by: Felix Exner (fexner) <[email protected]>
Co-authored-by: Felix Exner (fexner) <[email protected]>
Co-authored-by: Felix Exner (fexner) <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last formatting issue, then I think this is ready to squash-merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good! I'll wait whether the CI gets to a sensible state before merging.
Edit: Looking at my changes from #17 we need to add building gz_ros2_control from source to the installation instructions.
As requested in #26, this PR adds the necessary documentation for this package, containing basic usage, customization options and limitations.
It will be followed by an additional PR for the documentation package to add it to the full documentation ecosystem.