-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version detection #3364
Update version detection #3364
Conversation
Wow @dopplershift, there's python foo I have never seen before here, ufff. Indeed, testing this import metpy
|
Try to avoid pulling in setuptools_scm for better import time by directly checking for a pip file that indicates whether the install is editable and only using the git-based version in that case; otherwise, depend on the distribution metadata.
3a82a1e
to
0082df8
Compare
Regarding tests and coverage, I believe our thinking in the past was that we make sure CI covers the path for the released code, and our dev installs will cover...well the dev path. I don't think there's a good way to test this that doesn't essentially mock things out based on the implementation or require another CI job that uses a dev-style (editable) install. |
@dcamron We can ignore the coverage failure here, so this is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. I'd meant to make room for the testing/coverage discussion, but I'm happy with your summary above. 👍
The important part is that we don't release a broken package, and I'm confident we're testing for that. |
Description Of Changes
Try to avoid pulling in setuptools_scm for better import time by directly checking for a pip file that indicates whether the install is editable and only using the git-based version in that case; otherwise, depend on the distribution metadata.
Alternative to #3363.