-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Qudi spectrometer #598
Draft
alrik-durand
wants to merge
54
commits into
Ulm-IQO:master
Choose a base branch
from
alrik-durand:qudi_spectrometer_wip
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I try to determine which functions are needed in our logic module on the basis than the current camera interface do not offer enough functions for enough practival uses.
add comments
New function less dict arguments
read mode parameters functions change
New functions name
camera method added (+decorator)
Camera wrapper OK
Please take a look on our first logic complete version
I don't remembre what I did !
Add constraint functions + change the doctypes + change aqusition to asynchrone + change the test
I updated functions and doctype related to what I did on the logic module
advanced version of camera hardware and interface (missing SI units checking, code checking ..)
ready for review
Don't care about this commit, this will be changed soon
Correction from last review
change the constraints dict and some outdated names
It is nice to hear that spectrometers modules are developed! For a couple of months, I used qudi to control Princeton Instruments cameras and monochromators (i300, sp2300) and some HORIBA spectrometers (FHR1000 and HR640). Please have a look in https://github.com/Fellow-baka/qudi/tree/HFML-spectroscopy |
11 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a draft PR, the work is not finished yet, we we though it would be good to inform the community of our projects.
We are writing new hardware/interface/logic/GUI to interface spectrometers in Qudi.
Our goal is to develop the necessary tools to get completely rid of usual closed software for the most usual tasks.
We also aim at developing a "user friendly" basic interface to facilitate the alignment and calibration processes that can sometimes be time consuming for the experimentalist.
Our PR adds two distinct interfaces : one for the camera and one for the gratings part.
Hardware and interfaces are nearly completed, the logic and GUI are a work in progress (not ready for review).
Motivation and Context
The current spectrometer modules only respond to very basic needs.
We are using spectrometers quite often in our lab and wanted dedicated modules for the task. Our developments aim a being this general platform with Qudi's principles in mind.
That is why we are opening this PR to tell other people of our plans.
Our day-to-day changes will not be pushed on this branch, as it would probably generate a lot of mail, we will therefore mainly use the "qudi_spectrometer" branch of my repo for now. I will update this branch when things are ready for review if that is ok with you.
How Has This Been Tested?
This is not tested, this is a WIP. A new PR will be opened the day it is ready enough.
Types of changes
Checklist:
documentation/changelog.md
)