New getAllInventoriesandYears method #171
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create new global dictionary, STEWI_DATA_VINTAGES, which needs to be manually updated when new standardized inventories become available. Create new global method, linear_search, for reverse searching a list and pulling the index of the value up to but not greater than a given value. Create new init method, getAllInventoriesandYears, to companion with getAvailableInventoriesandYears; the former returns the STEWI_DATA_VINTAGES dictionary if no year is given; otherwise, uses the linear search to get the most appropriate inventory years for a given year.
bl-young
requested changes
Jan 21, 2025
| 'NEI': [2011, 2014, 2017, 2020], | ||
| 'RCRAInfo': [x for x in range(2011, 2023, 2)], | ||
| 'TRI': [x for x in range(2011, 2023, 1)], | ||
| } |
There was a problem hiding this comment.
I think until we have fully validated outputs, we should stick to the years we do, so that would be nothing after 2021 for TRI, DMR, GHGRP, and RCRAInfo
|
otherwise works great, thanks! |
|
Do you really want me to make those changes?
…On Tue, Jan 21, 2025, 15:10 Ben Young (ERG) ***@***.***> wrote:
otherwise works great, thanks!
—
Reply to this email directly, view it on GitHub
<#171 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHCFB5MLD2RED6XHQ5LX5AD2L2SUBAVCNFSM6AAAAABVTGOQDGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBVGY2DEMZVGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #150.