Created a new file named randomNumber.py #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makapx
approved these changes
Oct 30, 2023
simone989
reviewed
Oct 31, 2023
tests/calculator.py
Outdated
| print("\nThe sum is:",int(x) + int(y)) | ||
| print("The difference is:", int(x)- int(y)) | ||
| print("The multiplication is: ", int(x) * int(y)) | ||
| print("The division is: ", float(x)/float(y)) |
There was a problem hiding this comment.
Aggiungi un blocco try/except per gestire le eccezioni che potrebbero essere scatenate da questo operatore.
simone989
reviewed
Oct 31, 2023
tests/calculator.py
Outdated
| print("\nThe sum is:",int(x) + int(y)) | ||
| print("The difference is:", int(x)- int(y)) | ||
| print("The multiplication is: ", int(x) * int(y)) | ||
| print("The division is: ", float(x)/float(y)) |
There was a problem hiding this comment.
Stai eseguendo il casting a int/float molteplici volte, fallo una volta sola in fase di definizione.
simone989
reviewed
Oct 31, 2023
tests/randomNumber.py
Outdated
| @@ -0,0 +1,3 @@ | |||
| import random | |||
There was a problem hiding this comment.
Importa solo la funzione randint dal modulo random.
simone989
reviewed
Oct 31, 2023
tests/randomNumber.py
Outdated
| @@ -0,0 +1,3 @@ | |||
| import random | |||
|
|
|||
| print("Your random number is:", random.randint(1,100)) | |||
There was a problem hiding this comment.
Definisci sempre i valori costanti in opportune variabili.
MIN_NUMBER=1
MAX_NUMBER= 100
simone989
reviewed
Oct 31, 2023
tests/verify.py
Outdated
|
|
||
| number = input("Enter a number to check if is present in the array:") | ||
|
|
||
| if int(number) in array: |
There was a problem hiding this comment.
Effettua il casting ad int in fase di definizione/assegnazione della variabile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.