Support multiple mount points #34
Conversation
rsync_to_rdisc.py
Outdated
| for mount_name in settings.transfer_settings: | ||
| mount_path = settings.transfer_settings[mount_name]['mount_path'] | ||
| # Check if mount is available and continue | ||
| if is_mount_available(mount_name, mount_path, run_file): | ||
| # Get folders to be transferred | ||
| to_be_transferred = get_folders_remote_server( | ||
| client, | ||
| settings.transfer_settings[mount_name], | ||
| run_file, | ||
| transferred_set | ||
| ) | ||
|
|
||
| # Rsync folders from HPC to mount | ||
| rsync_succes = rsync_server_remote(hpc_server, client, to_be_transferred, mount_path, run_file) | ||
| if not rsync_succes: | ||
| remove_run_file = False |
There was a problem hiding this comment.
Originally, a new rsync_to_rdisc process would be blocked when a mount was unavailable. Someone has to take a look and fix the mount, and I think to avoid many emails as well.
I think the new code changes this scenario; the sys.exit() is removed in is_mount_available.
Can be resolved with:
else:
remove_run_file = False
There was a problem hiding this comment.
I have implemented this but have to think about it. The problem is that we will now block bgarray transfers if for example the glims mount is not available. I am not sure if that is something we would like to do....
There was a problem hiding this comment.
I see. Let's think about a solution that continues bgarray transfer if glims is unavailable, and avoid multiple emails if a mount is lost. :)
Add support for multiple mount points.