Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTR Motion Correction #236

Merged
merged 5 commits into from
Jan 28, 2025
Merged

Conversation

alexdaniel654
Copy link
Member

@alexdaniel654 alexdaniel654 commented Jan 28, 2025

Adding motion correction (moco) to MTR class. Uses the mdreg package but as its fitting to a constant model, calling it MDR feels confusing.

Todo

  • Add mdreg to MTR
  • Add tests
  • Add example to notebook
  • Update documentation
  • Deal with pep8 issues
  • Maybe add np.clip to MTR map to get rid of large erroneous values.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.94%. Comparing base (8058af2) to head (c917c78).
Report is 6 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #236   +/-   ##
=======================================
  Coverage   97.94%   97.94%           
=======================================
  Files          48       48           
  Lines        4520     4534   +14     
=======================================
+ Hits         4427     4441   +14     
  Misses         93       93           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexdaniel654 alexdaniel654 merged commit d2b78c9 into UKRIN-MAPS:dev Jan 28, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant