vscode: use preview editors for json logs

tools/vscode/src/core/vscode/association.ts

@@ -0,0 +1,37 @@
+import { ConfigurationTarget, workspace } from "vscode";
+
+
+export interface EditorAssociation {
+  viewType: string;
+  filenamePattern: string;
+}
+
+
+export async function withEditorAssociation(
+  association: EditorAssociation,
+  fn: () => Promise<void>) {
+
+  // get existing associations
+  const kEditorAssociations = 'editorAssociations';
+  const config = workspace.getConfiguration('workbench');
+  const configuredAssociations: Record<string, string> | undefined = config.get(kEditorAssociations);
+  const existingAssociations = (configuredAssociations && Object.keys(configuredAssociations).length > 0)
+    ? configuredAssociations
+    : undefined;
+
+
+  // temporarily update
+  const updatedAssociations: Record<string, string> = {
+    ...existingAssociations,
+    [association.filenamePattern]: association.viewType
+  };
+  await config.update(kEditorAssociations, updatedAssociations, ConfigurationTarget.Workspace);
+
+  // execute and unwind update
+  try {
+    await fn();
+  } finally {
+    await config.update(kEditorAssociations, existingAssociations, ConfigurationTarget.Workspace);
+  }
+
+}

tools/vscode/src/providers/openlog.ts

@@ -3,6 +3,7 @@ import { kInspectLogViewType } from "./logview/logview-editor";
 import { hasMinimumInspectVersion } from "../inspect/version";
 import { kInspectEvalLogFormatVersion } from "./inspect/inspect-constants";
 import { InspectViewManager } from "./logview/logview-view";
+import { withEditorAssociation } from "../core/vscode/association";
 
 
 export function activateOpenLog(
@@ -12,23 +13,30 @@ export function activateOpenLog(
 
   context.subscriptions.push(commands.registerCommand('inspect.openLogViewer', async (uri: Uri) => {
 
+    // function to open using defualt editor in preview mode
+    const openLogViewer = async () => {
+      await commands.executeCommand(
+        'vscode.open',
+        uri,
+        <TextDocumentShowOptions>{ preview: true }
+      );
+    }
+
     if (hasMinimumInspectVersion(kInspectEvalLogFormatVersion)) {
       if (uri.path.endsWith(".eval")) {
-        // normal default path for .eval files (so they get preview treatment)
-        await commands.executeCommand(
-          'vscode.open',
-          uri,
-          <TextDocumentShowOptions>{ preview: true }
-        );
+
+        await openLogViewer();
+
       } else {
-        // force our custom editor for .json as we aren't the default. this has the issue of not 
-        // using preview so proliferates more editors
-        await commands.executeCommand(
-          'vscode.openWith',
-          uri,
-          kInspectLogViewType,
-          <TextDocumentShowOptions>{ preview: true }
+
+        await withEditorAssociation(
+          {
+            viewType: kInspectLogViewType,
+            filenamePattern: "{[0-9][0-9][0-9][0-9]}-{[0-9][0-9]}-{[0-9][0-9]}T{[0-9][0-9]}[:-]{[0-9][0-9]}[:-]{[0-9][0-9]}*{[A-Za-z0-9]{21}}*.json"
+          },
+          openLogViewer
         );
+
       }
 
       // notify the logs pane that we are doing this so that it can take a reveal action