Append tools in _basic_agent.py (#1207)

* Append tools in _basic_agent.py If tools where added to the state in `init` we should not override this. * Update CHANGELOG.md --------- Co-authored-by: jjallaire <[email protected]>
UKGovernmentBEIS · Jan 29, 2025 · b61c747 · b61c747
1 parent 8092509
commit b61c747
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,7 @@
 - Anthropic: Don't insert '(no content)' into cannonical messages list (do only on replay)
 - Anthropic: Use qualifiers rather than model args for Anthropic on other providers (`anthropic/bedrock`, `anthropic/vertex`).
 - Anthropic: Suport for `extra_body` model arg (for adding additional JSON properties to the request)
+- Basic Agent: Append `tools` to `state` so that tools added in `init` are preserved.
 - Scoring: Always provide half-again the sample time limit for scoring.
 - Bugfix: Fix issue w/ approvals for samples with id==0.
 - Bugfix: Use "plain" display when running eval_async() outside of eval().

diff --git a/src/inspect_ai/solver/_basic_agent.py b/src/inspect_ai/solver/_basic_agent.py
@@ -119,7 +119,7 @@ def basic_agent(
     # resolve tools
     if tools is None:
         tools = []
-    tools = tools if isinstance(tools, Solver) else use_tools(tools)
+    tools = tools if isinstance(tools, Solver) else use_tools(tools, append=True)
 
     # resolve score_value function
     score_value_fn = score_value or value_to_float()