Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PC-1294: Fix CSRF Fail #417

Merged
merged 1 commit into from
Dec 30, 2024
Merged

PC-1294: Fix CSRF Fail #417

merged 1 commit into from
Dec 30, 2024

Conversation

samyou-softwire
Copy link
Contributor

Link to Jira ticket

Description

specify CSRF_TRUSTED_ORIGINS environment variable

use the BASE_URL environment variable to make this work across environments

missed in django upgrade. see https://docs.djangoproject.com/en/5.1/releases/4.0/#csrf

Checklist

  • I have made any necessary updates to the documentation
  • I have checked there are no unnecessary IDE warnings in this PR
  • I have checked there are no unintentional line ending changes
  • I have added tests where applicable
  • If I have made any changes to the code, I have used the IDE auto-formatter on it
  • If I have made any changes to Python files (even if not changing any content strings), I have run make extract-translations

use the BASE_URL environment variable to make this work across environments
@samyou-softwire samyou-softwire self-assigned this Dec 30, 2024
Copy link
Contributor

@jdgage jdgage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assume this all works fine locally?

@samyou-softwire
Copy link
Contributor Author

Assume this all works fine locally?

yep, though not convinced the CSRF origin is checked locally anyway

@samyou-softwire samyou-softwire merged commit 2175249 into develop Dec 30, 2024
4 checks passed
@samyou-softwire samyou-softwire deleted the PC-1294-fix-csrf-fail branch December 30, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants