Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PC-1515: Fix for loft insulation error on check answers page #416

Merged
merged 2 commits into from
Dec 20, 2024
Merged

PC-1515: Fix for loft insulation error on check answers page #416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a65b10a
PC-1515: Add old copy to check_your_answers_options_map
samyou-softwire Dec 18, 2024
3e577f4
PC-1515: Extract translations
samyou-softwire Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions help_to_heat/frontdoor/schemas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,9 @@
"Apartment, flat or maisonette": _("apartment, flat or maisonette"),
}

# if wording changes, old answers should be left in this map
# otherwise, an error will be thrown on check answers page for these old users
# see loft_insulation_field for an example
check_your_answers_options_map = {
country_field: {
country_field_england: _("England"),
Expand Down Expand Up @@ -489,6 +492,8 @@
loft_insulation_field_no_insulation: _("I have no loft insulation"),
loft_insulation_field_dont_know: _("I do not know"),
loft_insulation_field_no_loft: _("No loft"),
# deprecated as part of PC-1364. see comment on this map
"I have up to 100mm of loft insulation": _("I have less than or equal to 100mm of loft insulation"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think put the comment on top of here and add a blank line if the formatter allows it - would more clearly delineate between real answers and the ones kept for backwards-compatibility

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather keep the main comment on the map as it applies to all pages in general, have added one to this line too. no newline allowed alas

},
}

Expand Down
Loading
Loading