PC-1294: Update Django version #415
Conversation
support is listed as removed in https://docs.djangoproject.com/en/5.1/releases/5.0/#features-removed-in-5-0
no longer has any function. removed in https://docs.djangoproject.com/en/5.1/releases/5.0/#features-removed-in-5-0
pyproject.toml
Outdated
| @@ -20,7 +20,7 @@ testino = "0.3.9" | |||
| optional = true | |||
|
|
|||
| [tool.poetry.group.deployment.dependencies] | |||
| django-gov-notify = "0.4.0" | |||
| django-gov-notify = "0.5.0" | |||
There was a problem hiding this comment.
There's a v0.6.0 as well - can we go to that?
There was a problem hiding this comment.
sure, by the looks of things it only changes version dependencies
pyproject.toml
Outdated
| @@ -33,7 +33,7 @@ python = "~3.11.9" | |||
| boto3 = "1.26.86" | |||
| botocore = "1.29.86" | |||
| debugpy = "1.6.7" | |||
| Django = "3.2.19" | |||
| Django = "5.1.1" | |||
There was a problem hiding this comment.
5.1.5 is the latest by the looks of things: would prefer to go to the latest patch
There was a problem hiding this comment.
I could only find 5.1.4
There was a problem hiding this comment.
Oh right yes, they've got patch notes on the site for 5.1.5 but it's not actually released yet
pyproject.toml
Outdated
| django-allauth = "0.54.0" | ||
| django-cors-headers = "4.0.0" | ||
| django-csp = "3.7" |
There was a problem hiding this comment.
Would be worth checking notes for all of these other Django-related packages to see if they support Django 5.x.
We're probably best off bumping all of them up to vLatest tbh
There was a problem hiding this comment.
have done most of these, though to note:
- the update for
django-allauthseems to be breaking, would need some more research into how we interact with this library django-use-email-as-usernameis now no longer actively maintained
There was a problem hiding this comment.
agreed in catchup to ensure django-allauth is compatible with django 5.0. backlog ticket to be raised for django-use-email-as-username
There was a problem hiding this comment.
have updated django-allauth to a version known to work with django 5.0. won't go any further as there are many breaking changes to consider https://docs.allauth.org/en/latest/release-notes/recent.html
requires adding a new middleware, as specified in 0.56.0 release notes https://docs.allauth.org/en/latest/release-notes/2023.html#id15 went as far as 0.58.2 for now, latest patch version after django 5.0 support was added in 0.58.0 https://docs.allauth.org/en/latest/release-notes/2023.html#id6
samyou-softwire
force-pushed
the
PC-1294-update-django-version
branch
from
745a39b to
42bd80e
Compare
Link to Jira ticket
Description
updates django to 5.1 & django-gov-notify to 0.5.0
makes upgrades, both mentioned in https://docs.djangoproject.com/en/5.1/releases/5.0/#features-removed-in-5-0:
USE_L10Nis no longer used, so is removedpytzpackage is no longer used, preferring python core packageshave tried frontdoor and portal, no issues found
Checklist
make extract-translations