Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PC-1465: stop old epcs showing in epc select #402

Merged
merged 8 commits into from
Nov 27, 2024
Merged

PC-1465: stop old epcs showing in epc select #402

merged 8 commits into from
Nov 27, 2024

Conversation

Glenn-Clarke
Copy link
Contributor

@Glenn-Clarke Glenn-Clarke commented Nov 25, 2024 •
edited
Loading

Link to Jira ticket

Description

Filters the returned list of EPCs for E&W to only include the most recent EPC for each UPRN present in the list.

Checklist

  • I have made any necessary updates to the documentation
  • I have checked there are no unnecessary IDE warnings in this PR
  • I have checked there are no unintentional line ending changes
  • I have added tests where applicable
  • If I have made any changes to the code, I have used the IDE auto-formatter on it
  • If I have made any changes to Python files (even if not changing any content strings), I have run make extract-translations
  • If I have made any changes to website flow, I have updated the Flow Miro Board
  • If I have made any changes to website flow, I have checked forward and back behaviour is still consistent

@Glenn-Clarke Glenn-Clarke marked this pull request as ready for review November 25, 2024 12:11
samyou-softwire
samyou-softwire requested changes Nov 25, 2024
View reviewed changes
tests/test_frontdoor.py Outdated Show resolved Hide resolved
help_to_heat/utils.py Outdated Show resolved Hide resolved
help_to_heat/utils.py Outdated Show resolved Hide resolved
help_to_heat/utils.py Outdated Show resolved Hide resolved
help_to_heat/utils.py Outdated Show resolved Hide resolved
tests/test_frontdoor.py Outdated Show resolved Hide resolved
samyou-softwire
samyou-softwire requested changes Nov 26, 2024
View reviewed changes
help_to_heat/utils.py Outdated Show resolved Hide resolved
tests/test_frontdoor.py Show resolved Hide resolved
jdgage
jdgage reviewed Nov 26, 2024
View reviewed changes
help_to_heat/utils.py Show resolved Hide resolved
tests/test_frontdoor.py Show resolved Hide resolved
@Glenn-Clarke Glenn-Clarke requested a review from jdgage November 26, 2024 14:07
jdgage
jdgage approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@jdgage jdgage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so as not to hold up releasing the fix while I quibble about tests

@Glenn-Clarke Glenn-Clarke merged commit 0a60278 into develop Nov 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samyou-softwire samyou-softwire samyou-softwire approved these changes

@jdgage jdgage jdgage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Glenn-Clarke @jdgage @samyou-softwire