Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PC-1364: Loft insulation question #398

Merged
merged 5 commits into from
Nov 14, 2024

Conversation

Glenn-Clarke
Copy link
Contributor

@Glenn-Clarke Glenn-Clarke commented Nov 13, 2024

Link to Jira ticket

Description

Added new answer, and reworded previous answers to be clearer.

Checklist

  • I have made any necessary updates to the documentation
  • I have checked there are no unnecessary IDE warnings in this PR
  • I have checked there are no unintentional line ending changes
  • I have added tests where applicable
  • If I have made any changes to the code, I have used the IDE auto-formatter on it
  • If I have made any changes to Python files (even if not changing any content strings), I have run make extract-translations
  • If I have made any changes to website flow, I have updated the Flow Miro Board
  • If I have made any changes to website flow, I have checked forward and back behaviour is still consistent

Screenshots

{C89EF502-6B7D-486C-89B4-A362C097231A}

@Glenn-Clarke Glenn-Clarke requested a review from jdgage November 13, 2024 14:36
Copy link
Contributor

@jdgage jdgage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a get_loft_insulation_answers in tests/routing that might want updating?

The ticket also says "This will result in the same outcome in the CSV as if selecting less than 100mm" - does this get handled?

@Glenn-Clarke
Copy link
Contributor Author

Ah! I'm working on the CSV handling now, I missed that part.

I've sorted out the tests locally in the meantime.

@Glenn-Clarke Glenn-Clarke requested a review from jdgage November 13, 2024 16:40
@Glenn-Clarke
Copy link
Contributor Author

It should now override the no_insulation answer into the less_than_threshold upon creation. So to a user during the journey, it will look as if they have chosen no_insulation, but to suppliers it will appear to be less_than_threshold :)

help_to_heat/frontdoor/interface.py Outdated Show resolved Hide resolved
@Glenn-Clarke Glenn-Clarke requested a review from jdgage November 13, 2024 17:23
@Glenn-Clarke Glenn-Clarke force-pushed the PC-1364-Loft-Insulation-Question branch from 7c34307 to c2ac62e Compare November 14, 2024 09:09
@Glenn-Clarke Glenn-Clarke merged commit 17aee3c into develop Nov 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants