-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PC-1364: Loft insulation question #398
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a get_loft_insulation_answers
in tests/routing
that might want updating?
The ticket also says "This will result in the same outcome in the CSV as if selecting less than 100mm" - does this get handled?
Ah! I'm working on the CSV handling now, I missed that part. I've sorted out the tests locally in the meantime. |
It should now override the no_insulation answer into the less_than_threshold upon creation. So to a user during the journey, it will look as if they have chosen no_insulation, but to suppliers it will appear to be less_than_threshold :) |
7c34307
to
c2ac62e
Compare
Link to Jira ticket
Description
Added new answer, and reworded previous answers to be clearer.
Checklist
make extract-translations
Screenshots