PC-1413: Remove "I don't know" option from EPC question #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Having some conflicts with the translations between these tickets, so will leave it conflicting for now and fix at the end. |
Glenn-Clarke
force-pushed
the
PC-1413-Remove-I-dont-know-from-EPC-question
branch
from
8f59806 to
872a1e7
Compare
jdgage
reviewed
Nov 12, 2024
| @@ -44,7 +44,6 @@ | |||
| epc_rating_field, | |||
| epc_select_manual_page, | |||
| epc_select_page, | |||
| field_dont_know, | |||
There was a problem hiding this comment.
Is this unused in the constants file now?
There was a problem hiding this comment.
I don't believe so, there's other questions that use this field in the consts.py file, as like "Yes" and "No" it's sort of a generic answer:
wall_insulation_field_dont_know = field_dont_know
This import in particular in schemas was unused once I removed its usage below, though.
jdgage
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira ticket
Description
Removed "I don't know" option from EPC question.
Checklist
make extract-translationsScreenshots