PC-1347: Routing error shown on success page #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samyou-softwire
force-pushed
the
PC-1347-routing-error-shown-on-success-page
branch
from
6df2fa1 to
29a2040
Compare
jdgage
reviewed
Nov 6, 2024
jdgage
reviewed
Nov 6, 2024
help_to_heat/frontdoor/views.py
Outdated
| return page_name_to_url(session_id, schemas.routing_overrides[page_name]["prev_page"]) | ||
| prev_page = schemas.routing_overrides[page_name]["prev_page"] | ||
| # if there is no previous page (or no back button at all), fall back to doing nothing | ||
| return page_name_to_url(session_id, prev_page if prev_page is not None else page_name) |
There was a problem hiding this comment.
Although maybe wants explaining what it means to return the current page name from this function?
There was a problem hiding this comment.
have extracted to a constant and provided some more details here
samyou-softwire
force-pushed
the
PC-1347-routing-error-shown-on-success-page
branch
from
29a2040 to
37067b6
Compare
jdgage
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira ticket
Description
adds a routing exception for the success page
in this case, the exception does nothing, so opted to mark it as
None. could have a different way of marking that there's no previous page forsuccess?Checklist
make extract-translations