PC-584 PC-514: unique identifier for each referral #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turns out i was initially wrong - it is possible to create the referral, then immediately query the generated id this simplifies the code TODO: fix emails
make the formatted name a computed property too, much more centralised than views.py
|
Only potential concern I can see is security audit complaining about publicly visible serial identifiers. They're not used as inputs anywhere though, so it should be fine? And I think something like GUIDs would be sufficiently user-unfriendly as to not be worth it. |
CheshireSwift
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes PC-584 & PC-514 (since they are so similar)
adds a new migration that adds a postgres SERIAL column to the database which assigns a unique referral id to each referral. this is true retroactively, existing referrals will be given a referral id
this referral id is shown at form completion
english:
welsh:
as well as included in emails
english:
welsh:
this referral id is then exported in the csv
the csv is now ordered by referral id. this is not specified in the ticket, but seemed the most sensible way to order things (previously no ordering was applied)