Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PC-570 wording changes following supplier feedback #259

Merged

Conversation

samyou-softwire
Copy link
Contributor

closes https://beisdigital.atlassian.net/browse/PC-570

a series of small wording changes & addition of extra paragraphs where needed

an example is given
old:
image

new:
image

new welsh:
image

@samyou-softwire samyou-softwire changed the base branch from main to develop January 8, 2024 11:00
Copy link
Contributor

@jamiehumphries jamiehumphries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of bits to change based on compliance with GOV.UK style. Otherwise, this looks good.

"No, there is less than 270mm of insulation in my loft": _(
"No, there is less than 270mm of insulation in my loft"
"I have up to 100 mm of loft insulation": _(
"I have up to 100 mm of loft insulation"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace all uses of 100 mm and 270 mm throughout with 100mm and 270mm (no space).

This is the expected style in the GOV.UK style guide:

Measurements

Use numerals and spell out measurements at first mention.

Do not use a space between the numeral and abbreviated measurement: 3,500kg not 3,500 kg.

Abbreviating kilograms to kg is fine - you do not need to spell it out.

Use ‘grams’ (not ‘grammes’). For example: micrograms, milligrams.

If the measurement is more than one word, like kilometres per hour, then spell it out the first time it’s used with the abbreviation. From then on, abbreviate. If it’s only mentioned once, do not abbreviate.

Use Celsius for temperature: 37°C

</h1>
</legend>
<p class="govuk-body">
{{_("A loft is fully insulated if it has more than 270mm (about 10-11 inches) of insulation covering the whole loft, usually laid on the 'floor' of the loft with one layer between the horizontal timbers and another layer going across them to bring the insulation up to the required level.")}}
{{_("A loft is fully insulated if it has 270 mm (about 10-11 inches) of insulation covering the whole loft, usually laid on the 'floor' of the loft with one layer between the horizontal timber joists and another layer going across them to bring the insulation up to the required level.")}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'floor' should be ‘floor’

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of the Welsh mixes between using ' and for apostrophes. We should be using .

Please can you replace these everywhere? We could take the opportunity to do it in all our strings.

@jamiehumphries jamiehumphries force-pushed the PC-570-wording-changes-following-supplier-feedback branch from 91423ef to da25ecf Compare January 18, 2024 13:28
@jamiehumphries jamiehumphries merged commit bb04097 into develop Jan 18, 2024
3 checks passed
@jamiehumphries jamiehumphries deleted the PC-570-wording-changes-following-supplier-feedback branch January 19, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants