Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create and connect js controller file #263

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

mlan225
Copy link
Member

@mlan225 mlan225 commented Jan 28, 2025

Resolves #262

B6 Form GDS auto calculation (checklist updated)

This PR focuses on the calculation of the fields

image

Original Review Specs

  • GDS score should auto calculate as user selects each radio button option
  • If any question has an option of Did not answer = 9 GDS score should be set to 88
  • GDS regular expression validation should be updated to allow 0
  • Form finalizes when all radios are input and NOGDS is false
  • Form gives an error when NOGDS is not checked and not all radio inputs are answered (unanswered radios display the error)
  • Form partial saves

Added Specs

  • GDS (question 16.) is a read-only field (from UDS3)
  • Unchecking the NOGDS checkbox will recalculate the GDS field with currently selected radio values
  • Radios selected while NOGDS is checked will result in the GDS total still being 88

@mlan225 mlan225 marked this pull request as draft January 28, 2025 22:01
@mlan225
Copy link
Member Author

mlan225 commented Jan 30, 2025

Spoke with Josh, bringing over functionality from UDS 3

  • Disable radio buttons when NOGDS is checked

We will not be focusing on disabling in this PR while we further inspect the form guide

@mlan225 mlan225 marked this pull request as ready for review January 30, 2025 19:27
@mlan225
Copy link
Member Author

mlan225 commented Jan 31, 2025

Modified the logic to remove disabling the radio buttons, in this PR we only want to run the auto calculations. Spoke with Ash about the form logic and we agreed to revisit the disable validation in a later card after inspecting the form guidelines further

@ashleybot ashleybot self-requested a review February 3, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

B6 GDS auto-calculation, and should allow 0
2 participants